Skip to content

Remove quoted pattern patterns #8743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 18, 2020
Merged

Remove quoted pattern patterns #8743

merged 2 commits into from
Apr 18, 2020

Conversation

nicolasstucki
Copy link
Contributor

This are quite limited and not use case has ben found so far.
They could be added back leater if needed.

@nicolasstucki
Remove quoted pattern patterns
aab688e 
This are quite limited and not use case has ben found so far.
They could be added back leater if needed.
@nicolasstucki nicolasstucki self-assigned this Apr 17, 2020
@bishabosha
Copy link
Member

would this close #8179 ?

@nicolasstucki
Copy link
Contributor Author

It seems it would

liufengyun
liufengyun approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nicolasstucki nicolasstucki marked this pull request as ready for review April 18, 2020 04:58
@nicolasstucki nicolasstucki merged commit 3a5c390 into scala:master Apr 18, 2020
@nicolasstucki nicolasstucki deleted the remove-quote-pattern-pattern branch April 18, 2020 04:59
@nicolasstucki
Copy link
Contributor Author

Use the reflection API instead.

@bishabosha bishabosha mentioned this pull request Apr 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@nicolasstucki nicolasstucki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolasstucki @bishabosha @liufengyun